Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chromium browser #1888

Merged
merged 75 commits into from
Feb 17, 2025
Merged

add chromium browser #1888

merged 75 commits into from
Feb 17, 2025

Conversation

maddog1110
Copy link
Contributor

@maddog1110 maddog1110 commented Dec 4, 2024

Chromium Browser App for Umbrel

A full-featured Chromium browser with secure remote access, powered by LinuxServer.io.

Features

  • Secure remote browser access through port 30099
  • Built-in authentication
  • Automatic startup
  • Full Chromium features

Testing

  • Tested on Umbrel
  • Tested on Linux VM
  • Tested on Raspberry Pi

Gallery Images

  1. https://raw.githubusercontent.com/maddog1110/umbrel-apps/refs/heads/master/apps/chromium-browser/google.png
  2. https://github.com/maddog1110/umbrel-apps/blob/master/apps/chromium-browser/youtube.png
  3. https://github.com/maddog1110/umbrel-apps/blob/master/apps/chromium-browser/amazon.png

@dirstel
Copy link
Contributor

dirstel commented Dec 6, 2024

Maybe the docker-compose.yml is missing here...?

@maddog1110
Copy link
Contributor Author

I just did thx

Copy link
Contributor

@sharknoon sharknoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maddog1110 for submitting this app. I am really looking forward to having a fully featured chromium browser installed on umbrelOS.

I have left some suggestions for improvements below:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a svg icon. Here is one from Wikipedia:
Google_Chrome_icon_(February_2022)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@maddog1110 maddog1110 marked this pull request as draft December 31, 2024 22:40
@maddog1110 maddog1110 marked this pull request as ready for review December 31, 2024 22:40
@maddog1110 maddog1110 marked this pull request as draft January 9, 2025 23:59
@maddog1110 maddog1110 marked this pull request as ready for review January 9, 2025 23:59
@maddog1110 maddog1110 marked this pull request as draft January 10, 2025 00:00
@maddog1110 maddog1110 marked this pull request as ready for review January 10, 2025 00:00
@maddog1110 maddog1110 changed the title add chromium browser app add chromium browser Jan 31, 2025
@maddog1110 maddog1110 marked this pull request as draft January 31, 2025 00:44
@maddog1110 maddog1110 marked this pull request as ready for review January 31, 2025 00:44
@nmfretz
Copy link
Contributor

nmfretz commented Feb 12, 2025

Hey @maddog1110. I have gone through and finalized this submission by addressing @sharknoon's suggestions. We'll get the gallery assets together and then this can go live 🎉

I've pushed atomic commits so you can easily see the changes and understand what happened.

Thanks again for the submission!

@maddog1110
Copy link
Contributor Author

maddog1110 commented Feb 12, 2025

@nmfretz look great

Copy link

⚠️   Linting finished with 1 warning   ⚠️

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
⚠️ chromium/umbrel-app.yml "icon" and "gallery" needs to be empty for new app submissions:
The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Feb 17, 2025

Gallery assets have been prepared. Going live.

Thanks again for adding Chromium @maddog1110!

image

@nmfretz nmfretz merged commit 5269229 into getumbrel:master Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants